Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754490AbaLBRrZ (ORCPT ); Tue, 2 Dec 2014 12:47:25 -0500 Received: from mail-vc0-f180.google.com ([209.85.220.180]:43071 "EHLO mail-vc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754366AbaLBRrT (ORCPT ); Tue, 2 Dec 2014 12:47:19 -0500 MIME-Version: 1.0 In-Reply-To: <547D6F36.50103@rock-chips.com> References: <1415970338-2637-1-git-send-email-addy.ke@rock-chips.com> <1416903008-4160-1-git-send-email-addy.ke@rock-chips.com> <547D6F36.50103@rock-chips.com> Date: Tue, 2 Dec 2014 09:47:18 -0800 X-Google-Sender-Auth: H7za1kIGC9bBoeGF-49d80C6TGc Message-ID: Subject: Re: [PATCH v2] mmc: dw_mmc: add quirk for broken data transfer over scheme From: Doug Anderson To: addy ke Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Seungwon Jeon , Jaehoon Chung , Chris Ball , Ulf Hansson , Dinh Nguyen , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Olof Johansson , Sonny Rao , Alexandru Stan , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "zhenfu.fang" , Eddie Cai , lintao , chenfen , zyf , Jianqun Xu , Tao Huang , Chris , =?UTF-8?B?5aea5pm65oOF?= , han jiang , Kever Yang , zhangqing , Lin Huang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Addy, On Mon, Dec 1, 2014 at 11:50 PM, addy ke wrote: > We don't know why we have this problem, > but this problem is really exist, and we need patch to fix this problem now. > I will post a follow up change when we find the root cause. To me that seems reasonable. Certainly I would prefer to have this patch while waiting for the root cause, but it's up to Ulf. > And there is a little probability of this problem on RK SoC, such as RK3188, RK3066, > when worse card inserted in. > Maybe the other SoCs have the similar problem. > > So I will add this quirk in rockchip code(dw_mmc-rockchip.c) as follows: > static int dw_mci_rockchip_parse_dt(struct dw_mci *host) > { > host->quirk |= DW_MCI_QUIRK_BROKEN_DTO; > > return 0; > } > > ...... > .parse_dt = dw_mci_rockchip_parse_dt, > ...... > > is right? When you added "sdio_id0" you got feedback that you should use dw_mci_rockchip_init(). Why not do the same thing here? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/