Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932817AbaLBR5a (ORCPT ); Tue, 2 Dec 2014 12:57:30 -0500 Received: from mail-vc0-f175.google.com ([209.85.220.175]:64703 "EHLO mail-vc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932550AbaLBR52 (ORCPT ); Tue, 2 Dec 2014 12:57:28 -0500 MIME-Version: 1.0 In-Reply-To: <1417531766-29669-2-git-send-email-jay.xu@rock-chips.com> References: <1417531766-29669-1-git-send-email-jay.xu@rock-chips.com> <1417531766-29669-2-git-send-email-jay.xu@rock-chips.com> Date: Tue, 2 Dec 2014 09:57:27 -0800 X-Google-Sender-Auth: yb7xpA1UaeTIKVOKH9c5JteKD1g Message-ID: Subject: Re: [PATCH 1/2] ASoC: rockchip-i2s: dt: add an optional property "i2s_clk_out" From: Doug Anderson To: Jianqun Xu Cc: Liam Girdwood , "broonie@kernel.org" , perex@perex.cz, tiwai@suse.de, Sonny Rao , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "linux-arm-kernel@lists.infradead.org" , alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jianqun, On Tue, Dec 2, 2014 at 6:49 AM, Jianqun Xu wrote: > Add an property "i2s_clk_out", which enables to output clock to outside > of rockchip SoCs. Let's make it optional since not each board needs it. > > Signed-off-by: Jianqun Xu > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) You forgot to mention that this is a v3 in the subject line and forgot to mention what changed between v2 and v3 (nothing changed, but you should say that). Despite that, this patch looks reasonable to me. Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/