Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933285AbaLBWXx (ORCPT ); Tue, 2 Dec 2014 17:23:53 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:47965 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932550AbaLBWXv (ORCPT ); Tue, 2 Dec 2014 17:23:51 -0500 Message-ID: <547E3BF5.5060201@lwfinger.net> Date: Tue, 02 Dec 2014 16:23:49 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: =?UTF-8?B?TWljaGFlbCBCw7xzY2g=?= , Andrey Skvortsov CC: "Rafael J. Wysocki" , Gary.Zambrano@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, b43-dev , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH] SSB / B44: fix WOL for BCM4401 References: <20141201111125.GA11974@localhost.localdomain> <1417466798-15735-1-git-send-email-Andrej.Skvortzov@gmail.com> <20141201221023.79ffb40d@wiggum> <20141202200129.GA4580@crion89> <20141202211211.7e08b935@wiggum> In-Reply-To: <20141202211211.7e08b935@wiggum> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/2014 02:12 PM, Michael Büsch wrote: > On Tue, 2 Dec 2014 23:01:29 +0300 > Andrey Skvortsov wrote: > >> On Mon, Dec 01, 2014 at 10:10:23PM +0100, Michael Büsch wrote: >>> On Mon, 1 Dec 2014 23:46:38 +0300 >>> Andrey Skvortsov wrote: >>> >>>> Wake On Lan was not working on laptop DELL Vostro 1500. >>>> If WOL was turned on, BCM4401 was powered up in suspend mode. LEDs blinked. >>>> But the laptop could not be woken up with the Magic Packet. The reason for >>>> that was that PCIE was not enabled as a system wakeup source and >>>> therefore the host PCI bridge was not powered up in suspend mode. >>>> PCIE was not enabled in suspend by PM because no child devices were >>>> registered as wakeup source during suspend process. >>>> On laptop BCM4401 is connected through the SSB bus, that is connected to the >>>> PCI-Express bus. SSB and B44 did not use standard PM wakeup functions >>>> and did not forward wakeup settings to their parents. >>>> To fix that B44 driver enables PM wakeup and registers new wakeup source >>>> using device_set_wakeup_enable(). Wakeup is automatically reported to the parent SSB >>>> bus via power.wakeup_path. SSB bus enables wakeup for the parent PCI bridge, if there is any >>>> child devices with enabled wakeup functionality. All other steps are >>>> done by PM core code. >>> >>> Thanks, this looks good. >>> I assume you tested this (I currently don't have a device to test this). >> >> Sure, I've tested it. WOL from suspend is working and after resume from hibernate Ethernet is working too. > > That sounds good, indeed. > I'd still prefer, if someone with b43 (wireless) would test it, too. I did a partial test with my PowerBook G4. With the patch installed, it would both suspend and hibernate, but WOL would be impossible. This computer uses a PCMCIA version of the BCM4318, and power is turned off to the PCMCIA card when suspended or hibernating. If WOL works for the OP, then I think we can ACK this patch. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/