Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbaLCDnP (ORCPT ); Tue, 2 Dec 2014 22:43:15 -0500 Received: from ozlabs.org ([103.22.144.67]:59393 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbaLCDnO (ORCPT ); Tue, 2 Dec 2014 22:43:14 -0500 Message-ID: <1417578191.16722.11.camel@concordia> Subject: Re: [PATCH v5] selftest: size: Add size test for Linux kernel From: Michael Ellerman To: Tim Bird Cc: Shuah Khan , "linux-api@vger.kernel.org" , Josh Triplett , "linux-kernel@vger.kernel.org" , "linux-embedded@vger.kernel.org" Date: Wed, 03 Dec 2014 14:43:11 +1100 In-Reply-To: <547E854E.5060101@sonymobile.com> References: <547E854E.5060101@sonymobile.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-12-02 at 19:36 -0800, Tim Bird wrote: > This test shows the amount of memory used by the system. > Note that this is dependent on the user-space that is loaded > when this program runs. Optimally, this program would be > run as the init program itself. Sorry to only chime in at v5. > diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile > new file mode 100644 > index 0000000..47f8e9c > --- /dev/null > +++ b/tools/testing/selftests/size/Makefile > @@ -0,0 +1,15 @@ > +#ifndef CC > + CC = $(CROSS_COMPILE)gcc > +#endif I think the following is preferable: CC := $(CROSS_COMPILE)$(CC) It allows optionally setting a custom CC, as well as optionally CROSS_COMPILE. The only thing it doesn't do is choose gcc explicitly, but you shouldn't really do that anyway - unless you absolutely require gcc. Let the user choose their compiler by choosing where cc points. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/