Date: Fri, 27 Dec 2002 16:00:52 -0500 (EST)
From: Matthew Zahorik <matt@albany.net>
To: linux-kernel@vger.kernel.org
Subject: Hang on partition check, 2.4 kernels
Message-ID: <Pine.BSF.4.43.0212271544210.3244-100000@ender.tmmz.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1668
Lines: 49

I have a sparc SS10 that I recently installed with Debian 3.0r0.

There are two drives in the machine, sda (ID #1) and sdb (ID #3)

sda is dead, sdb is functioning fine.

Rather than awaiting a replacement for sda, I went ahead and installed
Debian on sdb.  Worked fine.  Happy day.

Debian 3.0r0 on sparc32 installs a 2.2.20 kernel.  Obtained and compiled
2.4.20.  Rebooted.

The 2.4.20 kernel hangs forever waiting to read the partitions on sda.

2.2.20 didn't do this.  It printed a message about failing to read the
table, then continued.

Wandered through the 2.2.20 and 2.4.20 code and compared.

In 2.2.20, the partition check for Sun is in
drivers/block/genhd.c:sun_partition()

This code calls bread() directly, immediately handling the error and
skipping a bad drive.

In 2.4.20, the partition check for Sun is in
fs/partitions/sun.c:sun_partition()

This calls read_dev_sector in fs/partitions/check.c, which
calls read_cache_page then calls wait_on_page is there is an error.
This seems to wait forever.

Can someone explain how/why read_cache_page is called, how it's wrong, and
why bread() isn't sufficient in this function?  I don't know how to fix
the code once VM got involved.

I could simply pull the damaged drive and the machine would boot (I'd have
to adjust root to point to sda instead of sdb...)  But I'd like to fix
the behavior now - the machine should boot despite the failure.

Thanks!

- Matt

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/