Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbaLCG6q (ORCPT ); Wed, 3 Dec 2014 01:58:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49810 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbaLCG6p (ORCPT ); Wed, 3 Dec 2014 01:58:45 -0500 Date: Wed, 03 Dec 2014 07:58:43 +0100 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , Benoit Taine , Bjorn Helgaas , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: azt3328.c: Cleaning up function that are not used anywhere In-Reply-To: <1417561690-27471-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1417561690-27471-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 3 Dec 2014 00:08:09 +0100, Rickard Strandqvist wrote: > > Remove function snd_azf3328_codec_outl() that is not used anywhere. This is a small inliner and no problem to keep it. Removing it breaks the code balance, and one would have to re-add it if 32bit register address is needed in the future patch. thanks, Takashi > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > sound/pci/azt3328.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c > index 5a69e26..82da7b9 100644 > --- a/sound/pci/azt3328.c > +++ b/sound/pci/azt3328.c > @@ -379,15 +379,6 @@ snd_azf3328_codec_inw(const struct snd_azf3328_codec_data *codec, unsigned reg) > } > > static inline void > -snd_azf3328_codec_outl(const struct snd_azf3328_codec_data *codec, > - unsigned reg, > - u32 value > -) > -{ > - outl(value, codec->io_base + reg); > -} > - > -static inline void > snd_azf3328_codec_outl_multi(const struct snd_azf3328_codec_data *codec, > unsigned reg, const void *buffer, int count > ) > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/