Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbaLCJvH (ORCPT ); Wed, 3 Dec 2014 04:51:07 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:49518 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbaLCJvC convert rfc822-to-8bit (ORCPT ); Wed, 3 Dec 2014 04:51:02 -0500 From: Arnd Bergmann To: Lyra Zhang Cc: Murali Karicheri , Chunyan Zhang , Grant Likely , "robh+dt@kernel.org" , Catalin Marinas , "gregkh@linuxfoundation.org" , "ijc+devicetree@hellion.org.uk" , "jslaby@suse.cz" , Kumar Gala , Mark Brown , Mark Rutland , Pawel Moll , Ramkumar Ramachandra , "rrichter@cavium.com" , Will Deacon , "gnomes@lxorguk.ukuu.org.uk" , Jonathan Corbet , "jason@lakedaemon.net" , Mark Brown , Heiko =?ISO-8859-1?Q?St=FCbner?= , "shawn.guo@freescale.com" , "florian.vaussard@epfl.ch" , "andrew@lunn.ch" , Hayato Suzuki , Orson Zhai , "geng.ren@spreadtrum.com" , "zhizhou.zhang" , "lanqing.liu@spreadtrum.com" , Wei Qiao =?utf-8?B?KOS5lOS8nyk=?= , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "sprdlinux@freelists.org" , "linux-doc@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support Date: Wed, 03 Dec 2014 10:50:17 +0100 Message-ID: <3212776.kDbe7yX4eX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1416917818-10506-1-git-send-email-chunyan.zhang@spreadtrum.com> <54761BFC.4020705@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V02:K0:seEjlq4/vOV+Iw7pQsJtFN1lFi7+eGd5v37XbTojfoo 5o36cXBabzdNhfHSwivxD+KeKG2mYm+syWXW/k2M+JakIT9Pj9 F66CLsBGQH/hn9BUXiX3i/8cCM8b78dkzdJLL9hmYCj478jX6K prKH9So0KnPfakXN4/oI0I7cUxLcBoRVH41xq0oZZXc2w+VpR9 hoCacZoMJnXnRmiuwEUC94jKsc1cFo5wFeFFLI9sRKoYWXlqRF M3aH8wUWXhtnbBAlDTKQ3/vvk3z3Dcy1Sx1/fB2f64gCWf8thp OADaq2enwkDRY2bnMf44vZjSFMWivsn62VQ0sOGoA9DwDFoitk L/Bf7z7+lVj8C6+RY3CI= X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote: > 2014-11-27 2:29 GMT+08:00 Murali Karicheri : > > How about sorting this includes? asm/irq.h go first followed linux/ in alphabatical order? > > There are a few compile warnings if I moved asm/irq.h to the top of > all included files. The order that Murali meant is - first all linux/*.h headers, sorted alphabetically - then all asm/*.h headers, again sorted alphabetically This is the recommended style in general. > Warning details are below: > > In file included from drivers/tty/serial/sprd_serial.c:14:0: > ./arch/arm64/include/asm/irq.h:6:39: warning: ‘struct pt_regs’ > declared inside parameter list [enabled by default] > extern void (*handle_arch_irq)(struct pt_regs *); > ^ > ./arch/arm64/include/asm/irq.h:6:39: warning: its scope is only this > definition or declaration, which is probably not what you want > [enabled by default] > ./arch/arm64/include/asm/irq.h:8:54: warning: ‘struct pt_regs’ > declared inside parameter list [enabled by default] > extern void set_handle_irq(void (*handle_irq)(struct pt_regs *)); > I would consider this a (minor) bug in asm/irq.h. If you don't mind, please submit a patch to add a line with 'struct pt_regs;' to asm/irq.h. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/