Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbaLCKL5 (ORCPT ); Wed, 3 Dec 2014 05:11:57 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:35413 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751843AbaLCKLz (ORCPT ); Wed, 3 Dec 2014 05:11:55 -0500 Date: Wed, 3 Dec 2014 10:11:09 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Lyra Zhang , Mark Rutland , "gnomes@lxorguk.ukuu.org.uk" , Heiko =?iso-8859-1?Q?St=FCbner?= , Mark Brown , Catalin Marinas , Will Deacon , "andrew@lunn.ch" , "linux-api@vger.kernel.org" , "jslaby@suse.cz" , Ramkumar Ramachandra , "lanqing.liu@spreadtrum.com" , Wei Qiao =?utf-8?B?KOS5lOS8nyk=?= , Jonathan Corbet , Chunyan Zhang , "zhizhou.zhang" , "geng.ren@spreadtrum.com" , Murali Karicheri , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" , Grant Likely , Orson Zhai , "florian.vaussard@epfl.ch" , "devicetree@vger.kernel.org" , "jason@lakedaemon.net" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , Hayato Suzuki , "rrichter@cavium.com" , Mark Brown , "sprdlinux@freelists.org" , "shawn.guo@freescale.com" , "gregkh@linuxfoundation.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Kumar Gala Subject: Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support Message-ID: <20141203101109.GB11285@n2100.arm.linux.org.uk> References: <1416917818-10506-1-git-send-email-chunyan.zhang@spreadtrum.com> <54761BFC.4020705@ti.com> <3212776.kDbe7yX4eX@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3212776.kDbe7yX4eX@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 03, 2014 at 10:50:17AM +0100, Arnd Bergmann wrote: > On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote: > > > 2014-11-27 2:29 GMT+08:00 Murali Karicheri : > > > How about sorting this includes? asm/irq.h go first followed linux/ in alphabatical order? > > > > There are a few compile warnings if I moved asm/irq.h to the top of > > all included files. > > The order that Murali meant is > > - first all linux/*.h headers, sorted alphabetically > - then all asm/*.h headers, again sorted alphabetically > > This is the recommended style in general. > > > Warning details are below: > > > > In file included from drivers/tty/serial/sprd_serial.c:14:0: > > ./arch/arm64/include/asm/irq.h:6:39: warning: ‘struct pt_regs’ > > declared inside parameter list [enabled by default] > > extern void (*handle_arch_irq)(struct pt_regs *); > > ^ > > ./arch/arm64/include/asm/irq.h:6:39: warning: its scope is only this > > definition or declaration, which is probably not what you want > > [enabled by default] > > ./arch/arm64/include/asm/irq.h:8:54: warning: ‘struct pt_regs’ > > declared inside parameter list [enabled by default] > > extern void set_handle_irq(void (*handle_irq)(struct pt_regs *)); > > > > I would consider this a (minor) bug in asm/irq.h. If you don't mind, > please submit a patch to add a line with 'struct pt_regs;' to > asm/irq.h. A better question is: why is a modern driver using asm/irq.h in the first place. We used to include that file when platforms defined IRQ numbers statically, but modern platforms don't do that, so it shouldn't be required anymore. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/