Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752951AbaLCMgt (ORCPT ); Wed, 3 Dec 2014 07:36:49 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:48859 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbaLCMgq (ORCPT ); Wed, 3 Dec 2014 07:36:46 -0500 MIME-Version: 1.0 In-Reply-To: <1417610024-29748-1-git-send-email-m.szyprowski@samsung.com> References: <1416814256-24288-3-git-send-email-a.hajda@samsung.com> <1417610024-29748-1-git-send-email-m.szyprowski@samsung.com> Date: Wed, 3 Dec 2014 13:36:44 +0100 X-Google-Sender-Auth: 7Gz_k1e_-9CtvwRDQfpc-OAjfu0 Message-ID: Subject: Re: [PATCH v2 2/7] ARM: Exynos: add support for sub-power domains From: Geert Uytterhoeven To: Marek Szyprowski Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Kukjin Kim , Inki Dae , Tobias Jakobi , Daniel Drake , Andrzej Hajda , Tomasz Figa , Pankaj Dubey , Amit Daniel Kachhap , Ulf Hansson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, On Wed, Dec 3, 2014 at 1:33 PM, Marek Szyprowski wrote: > diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > index abde1ea8a119..b884358ebb1a 100644 > --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > @@ -22,6 +22,8 @@ Optional Properties: > - pclkN, clkN: Pairs of parent of input clock and input clock to the > devices in this power domain. Maximum of 4 pairs (N = 0 to 3) > are supported currently. > +- samsung,power-domain: phandle to a master power domain that the given domain > + is a part of For new DTSes I'd recommend using the generic "power-domains" only. Or do you already have a DTS where tv-power-domain@10023C20 uses "samsung,power-domain" in the wild? > Node of a device using power domains must have a samsung,power-domain property > defined with a phandle to respective power domain. > diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c > index 20f267121b3e..fa9a47ddad81 100644 > --- a/arch/arm/mach-exynos/pm_domains.c > +++ b/arch/arm/mach-exynos/pm_domains.c > @@ -108,7 +108,7 @@ static int exynos_pd_power_off(struct generic_pm_domain *domain) > static __init int exynos4_pm_init_power_domain(void) > { > struct platform_device *pdev; > - struct device_node *np; > + struct device_node *np, *master_np; > > for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { > struct exynos_pm_domain *pd; > @@ -159,6 +159,15 @@ no_clk: > > pm_genpd_init(&pd->pd, NULL, !on); > of_genpd_add_provider_simple(np, &pd->pd); > + > + /* make master and slave hierarchy */ > + master_np = of_parse_phandle(np, "samsung,power-domain", 0); > + if (!master_np) > + master_np = of_parse_phandle(np, "power-domains", 0); > + if (master_np) { > + pm_genpd_add_subdomain_names(master_np->name, np->name); > + of_node_put(master_np); > + } -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/