Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbaLCNDJ (ORCPT ); Wed, 3 Dec 2014 08:03:09 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:36009 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbaLCNDH (ORCPT ); Wed, 3 Dec 2014 08:03:07 -0500 Message-ID: <1417611812.30615.28.camel@mm-sol.com> Subject: Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic From: "Ivan T. Ivanov" To: Soren Brinkmann Cc: Linus Walleij , Michal Simek , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alessandro Rubini , Heiko Stuebner , Laurent Pinchart , linux-rockchip@lists.infradead.org, linux-sh@vger.kernel.org, Bjorn Andersson , Beniamino Galvani Date: Wed, 03 Dec 2014 15:03:32 +0200 In-Reply-To: <1417137993-8337-8-git-send-email-soren.brinkmann@xilinx.com> References: <1417137993-8337-1-git-send-email-soren.brinkmann@xilinx.com> <1417137993-8337-8-git-send-email-soren.brinkmann@xilinx.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > Instead of the driver caring about implementation details like device > tree, just provide information about driver specific pinconf parameters > to pinconf-generic which takes care of parsing the DT. > > Signed-off-by: Soren Brinkmann brinkmann@xilinx.com> > --- > This is compile tested only. So, it's likely that it needs more tweaking > to make it actually work on HW. But it illustrates the potential > benefits of the pinconf-generic changes in this series. > --- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 125 +++---------------------------- > 1 file changed, 11 insertions(+), 114 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index b863b5080890..2db85e53ef73 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -131,14 +131,14 @@ struct pmic_gpio_state { > struct gpio_chip chip; > }; > > -struct pmic_gpio_bindings { > - const char*property; > - unsigned param; > +static const struct pinconf_generic_dt_params pmic_gpio_bindings[] = { > + {"qcom,pull-up-strength",PMIC_GPIO_CONF_PULL_UP,0}, > + {"qcom,drive-strength",PMIC_GPIO_CONF_STRENGTH,0}, > }; > > -static struct pmic_gpio_bindings pmic_gpio_bindings[] = { > - {"qcom,pull-up-strength",PMIC_GPIO_CONF_PULL_UP}, > - {"qcom,drive-strength",PMIC_GPIO_CONF_STRENGTH}, > +static const struct pin_config_item pmic_conf_items[] = { > + PCONFDUMP(PMIC_GPIO_CONF_PULL_UP, "pull-up-strength", NULL, true), s/pull-up-strength/qcom,pull-up-strength/ > + PCONFDUMP(PMIC_GPIO_CONF_STRENGTH, "drive-strength", NULL, true), > }; > I am not happy that we have to define the same think two times. Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/