Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbaLCPnh (ORCPT ); Wed, 3 Dec 2014 10:43:37 -0500 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:45008 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbaLCPng (ORCPT ); Wed, 3 Dec 2014 10:43:36 -0500 From: "Aneesh Kumar K.V" To: Vlastimil Babka , "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/thp: Allocate transparent hugepages on local node In-Reply-To: <547DD100.30307@suse.cz> References: <1417412803-27234-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20141201113340.GA545@node.dhcp.inet.fi> <87vblvh3b9.fsf@linux.vnet.ibm.com> <547DD100.30307@suse.cz> User-Agent: Notmuch/0.19+2~g32855b9 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-pc-linux-gnu) Date: Wed, 03 Dec 2014 21:13:06 +0530 Message-ID: <87fvcwbuyd.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14120315-0013-0000-0000-0000029831AC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vlastimil Babka writes: > On 12/01/2014 03:06 PM, Aneesh Kumar K.V wrote: >> "Kirill A. Shutemov" writes: >> >>> On Mon, Dec 01, 2014 at 11:16:43AM +0530, Aneesh Kumar K.V wrote: >>>> This make sure that we try to allocate hugepages from local node if >>>> allowed by mempolicy. If we can't, we fallback to small page allocation >>>> based on mempolicy. This is based on the observation that allocating pages >>>> on local node is more beneficial that allocating hugepages on remote node. >>>> ........ ...... >>>> index e58725aff7e9..fa96af5b31f7 100644 >>>> --- a/mm/mempolicy.c >>>> +++ b/mm/mempolicy.c >>>> @@ -2041,6 +2041,46 @@ retry_cpuset: >>>> return page; >>>> } >>>> >>>> +struct page *alloc_hugepage_vma(gfp_t gfp, struct vm_area_struct *vma, >>>> + unsigned long addr, int order) > > It's somewhat confusing that the name talks about hugepages, yet you > have to supply the order and gfp. Only the policy handling is tailored > for hugepages. But maybe it's better than calling the function > "alloc_pages_vma_local_only_unless_interpolate" :/ > I did try to do an API that does struct page *alloc_hugepage_vma(struct vm_area_struct *vma, unsigned long addr) But that will result in further #ifdef in mm/mempolicy, because we will then introduce transparent_hugepage_defrag(vma) and HPAGE_PMD_ORDER there. I was not sure whether we really wanted that. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/