Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbaLCQvJ (ORCPT ); Wed, 3 Dec 2014 11:51:09 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:42604 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbaLCQvH (ORCPT ); Wed, 3 Dec 2014 11:51:07 -0500 MIME-Version: 1.0 In-Reply-To: <1417470961-16524-1-git-send-email-jilaiw@codeaurora.org> References: <1417470961-16524-1-git-send-email-jilaiw@codeaurora.org> Date: Wed, 3 Dec 2014 11:51:06 -0500 Message-ID: Subject: Re: [PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support From: Rob Clark To: Jilai Wang Cc: "dri-devel@lists.freedesktop.org" , linux-arm-msm , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 1, 2014 at 4:56 PM, Jilai Wang wrote: > + /* Enable HDCP Encryption */ > + hdmi_write(hdmi, REG_HDMI_HDCP_CTRL, BIT(0) | BIT(8)); btw, as Bjron mentioned, there are a lot of these open coded BIT(n).. but from a quick check, the first two or three I looked at, we already have the appropriate defines in the rnndb generated headers, to instead do: /* Enable HDCP Encryption */ hdmi_write(hdmi, REG_HDMI_HDCP_CTRL, HDMI_HDCP_CTRL_ENABLE | HDMI_HDCP_CTRL_ENCRYPTION_ENABLE); that seems somewhat more readable to me ;-) BR, -R -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/