Date: Wed, 3 Dec 2014 13:01:34 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Theodore Tso <tytso@mit.edu>
Subject: Re: [PATCH 3/3] ftracetests: Add test to test event filter logic
Message-ID: <20141203130134.117af4be@gandalf.local.home>
In-Reply-To: <CAMEtUuxjCQ_eZ9aMmzKWvQw55DO7vgVDN-8neAwR8W+Xdu3zwg@mail.gmail.com>
References: <20141203031334.174087814@goodmis.org>
	<20141203032106.156623189@goodmis.org>
	<CAMEtUuyzfKYVSJUra6nib-wWYQ91uEPC6mizF9PLpg+5Kjb+3w@mail.gmail.com>
	<20141203034033.19a30e2f@gandalf.local.home>
	<CAMEtUuxjCQ_eZ9aMmzKWvQw55DO7vgVDN-8neAwR8W+Xdu3zwg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Wed, 3 Dec 2014 09:53:18 -0800
Alexei Starovoitov <ast@plumgrid.com> wrote:

 
> aren't we all starting to hack things only to realize
> that the scope of work is too large? ;)

Yep. Although I did say I would only spend a few hours on a solution,
and would give up if it too longer. The patches themselves took much
shorter than I expected. It was writing the tests that brought me over
the brink. Although, I did a lot of manual tests to make sure things
did what was expected. But those manual tests need to become automatic
ones.


> Anyway, will try to add these tests when your patches land.

I'm placing the code changes in my 3.19 queue, and the test cases in my
3.20 queue. This is probably a good idea anyway, as the test cases will
fail if the code wasn't implemented, and the test goes in a separate
branch, where the code isn't implemented :-)  I did a merge to do the
test cases.

I also need to solve the busybox limitation. I don't know how that
shell can do bit logic, which is needed to verify that the filters
really did work.

-- Steve 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/