Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204AbaLDGnt (ORCPT ); Thu, 4 Dec 2014 01:43:49 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:63575 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753178AbaLDGnr (ORCPT ); Thu, 4 Dec 2014 01:43:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <547F3C9F.8080102@arm.com> <20141203172526.GC7712@sirena.org.uk> Date: Thu, 4 Dec 2014 12:13:46 +0530 Message-ID: Subject: Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts From: rajeev kumar To: Mark Brown Cc: Andrew Jackson , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Liam Girdwood , Liviu Dudau Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown wrote: >> On Wed, Dec 03, 2014 at 04:38:55PM +0000, Andrew Jackson wrote: >> >>> case SNDRV_PCM_TRIGGER_STOP: >>> case SNDRV_PCM_TRIGGER_SUSPEND: >>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH: >>> - dev->active--; >>> + if (dev->active > 0) >>> + dev->active--; >> >> How is this triggering - this sounds like you're papering over some >> other bug somewhere? This check can be removed as it is not going to triggered. B'rgds ~Rajeev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/