Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbaLDHW0 (ORCPT ); Thu, 4 Dec 2014 02:22:26 -0500 Received: from smtprelay06.ispgateway.de ([80.67.31.104]:41559 "EHLO smtprelay06.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbaLDHWZ (ORCPT ); Thu, 4 Dec 2014 02:22:25 -0500 References: <1398561815-22033-1-git-send-email-peter@piie.net> <1417184452-11884-1-git-send-email-peter@piie.net> <1417184452-11884-4-git-send-email-peter@piie.net> <20141203090436.GC52608@vmdeb7> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Peter Feuerer To: Darren Hart Cc: LKML , platform-driver-x86@vger.kernel.org, Andrew Morton , Zhang Rui , Andreas Mohr , Javi Merino Subject: Re: [RESEND PATCH v5 3/5] acerhdf: Use bang-bang thermal governor Date: Thu, 04 Dec 2014 08:21:06 +0100 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Df-Sender: NDA0MDk0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi again, Peter Feuerer writes: > Hi Darren, > > thank you very much for your reply. > > > Darren Hart writes: > >> On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote: >>> acerhdf has been doing an on-off fan control using hysteresis by >>> post-manipulating the outcome of thermal subsystem trip point handling. >>> This patch enables acerhdf to use the bang-bang governor, which is >>> intended for on-off controlled fans. >>> >>> Cc: platform-driver-x86@vger.kernel.org >>> Cc: Darren Hart >>> Cc: Andrew Morton >>> CC: Zhang Rui >>> Cc: Andreas Mohr >>> Cc: Javi Merino >>> Acked-and-tested-by: Borislav Petkov >>> Signed-off-by: Peter Feuerer >>> --- >>> drivers/platform/x86/Kconfig | 3 ++- >>> drivers/platform/x86/acerhdf.c | 36 +++++++++++++++++++++++++++++++----- >>> 2 files changed, 33 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >>> index a2eabe6..c173266 100644 >>> --- a/drivers/platform/x86/Kconfig >>> +++ b/drivers/platform/x86/Kconfig >>> @@ -38,7 +38,8 @@ config ACER_WMI >>> >>> config ACERHDF >>> tristate "Acer Aspire One temperature and fan driver" >>> - depends on THERMAL && ACPI >>> + select THERMAL_GOV_BANG_BANG >> >> So we use select sparingly as it does implicit things. >> >> I checked the THERMAL_GOV_BANG_BANG Kconfig entry, and the help says acerhdf >> already depends on it (which it doesn't appear to). Any particular reason to add >> select here instead of adding it as a depends. >> >> Why did you drop THERMAL? > > I had it like this in my first version of patches: > + depends on THERMAL && ACPI && THERMAL_GOV_BANG_BANG > > But after some discussion with lkml community we ended up with the select > line and dropped THERMAL dependency, as it is implied by > THEMAL_GOV_BANG_BANG. I'm not so experienced with Kconfig, so I must rely > on the statements of the community in this case. Just found the link about this discussion I had with Rui and Boris: http://linux-kernel.2935.n7.nabble.com/PATCH-0-4-acerhdf-thermal-adding-new-models-and-appropriate-governor-tp848572p908256.html [...] -- kind regards, --peter; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/