Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754131AbaLDKLd (ORCPT ); Thu, 4 Dec 2014 05:11:33 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:44521 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459AbaLDKL1 (ORCPT ); Thu, 4 Dec 2014 05:11:27 -0500 Date: Thu, 4 Dec 2014 10:11:31 +0000 From: Will Deacon To: Chunyan Zhang Cc: Catalin Marinas , "arnd@arndb.de" , "orsonzhai@gmail.com" , "zhang.lyra@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arm64/include/asm: Fixed a warning about 'struct pt_regs' Message-ID: <20141204101131.GE13224@arm.com> References: <1417674575-10855-1-git-send-email-chunyan.zhang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1417674575-10855-1-git-send-email-chunyan.zhang@spreadtrum.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 04, 2014 at 06:29:35AM +0000, Chunyan Zhang wrote: > If I include asm/irq.h on the top of my code, and set ARCH=arm64, > I'll get a compile warning, details are below: > warning: ‘struct pt_regs’ > declared inside parameter list [enabled by default] > > This patch is suggested by Arnd, see: > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/308270.html > > Signed-off-by: Chunyan Zhang > --- > arch/arm64/include/asm/irq.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h > index e1f7ecd..acedc7e 100644 > --- a/arch/arm64/include/asm/irq.h > +++ b/arch/arm64/include/asm/irq.h > @@ -3,6 +3,8 @@ > > #include > > +struct pt_regs; > + > extern void (*handle_arch_irq)(struct pt_regs *); > extern void migrate_irqs(void); > extern void set_handle_irq(void (*handle_irq)(struct pt_regs *)); Fair enough, applied with trivial conflict resolution. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/