Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbaLDLWM (ORCPT ); Thu, 4 Dec 2014 06:22:12 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:53396 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753499AbaLDLWJ (ORCPT ); Thu, 4 Dec 2014 06:22:09 -0500 From: Grant Likely Subject: Re: [PATCH] ARM: kbuild: Fix forced rebuild after 'make dtbs' To: Michal Marek , Linus Walleij , Russell King - ARM Linux Cc: Jason Cooper , Rob Herring , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" In-Reply-To: <547C7364.8000009@suse.cz> References: <1414961549-31666-1-git-send-email-jason@lakedaemon.net> <5474F78F.2060906@suse.cz> <20141125235150.GH3836@n2100.arm.linux.org.uk> <20141126005710.GE22670@titan.lakedaemon.net> <20141126144153.GK3836@n2100.arm.linux.org.uk> <547C7364.8000009@suse.cz> Date: Thu, 04 Dec 2014 11:22:01 +0000 Message-Id: <20141204112201.C824AC40992@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 01 Dec 2014 14:55:48 +0100 , Michal Marek wrote: > On 2014-11-28 15:10, Linus Walleij wrote: > > On Wed, Nov 26, 2014 at 3:41 PM, Russell King - ARM Linux > > wrote: > >> On Wed, Nov 26, 2014 at 02:57:42PM +0100, Linus Walleij wrote: > >>> make -f Makefile -j5 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > >>> KBUILD_OUTPUT=build-u300 u300_defconfig > >>> make -f Makefile -j5 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > >>> KBUILD_OUTPUT=build-u300 zImage CONFIG_DEBUG_SECTION_MISMATCH=y > >>> make -f Makefile -j5 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > >>> KBUILD_OUTPUT=build-u300 dtbs > >>> make -f Makefile -j5 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > >>> KBUILD_OUTPUT=build-u300 zImage CONFIG_DEBUG_SECTION_MISMATCH=y > >>> > >>> -> Rebuilds everything. > >>> > >>> This doesn't occur before the offending commit. So it only happens > >>> when specifying extra environment variables on the command line. > >> > >> I suspect if you also provide the CONFIG_DEBUG_SECTION_MISMATCH=y on the > >> dtbs line, everything will work properly. > > > > Yay, it works! :) > > > >> The problem is that dtbs line executes a prepare, which I guess rebuilds > >> the bounds stuff. So, the dtbs target results in it being rebuilt without > >> the section mismatch, and then you re-execute a make with it, causing > >> the bounds stuff to be rebuilt again. > > > > Yep. Not very intuitive to require passing section mismatch debug > > flags to DTB rebuilding but whatever, it's not so bad I can't live with > > it. > > Still, the dependency on the 'prepare' target is superfluous, if the > only requirement is that $(KERNELRELEASE) be set properly. So, I've lost track of where things stand on this issue. What is the current proposed fix? Make dtbs depend on 'scripts' and dtbs_install depend on 'prepare scripts'? Or is there a better way to make sure KERNELRELEASE is set for the dtbs_install target? g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/