Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754129AbaLDMqT (ORCPT ); Thu, 4 Dec 2014 07:46:19 -0500 Received: from mail-ig0-f176.google.com ([209.85.213.176]:48573 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908AbaLDMqS (ORCPT ); Thu, 4 Dec 2014 07:46:18 -0500 MIME-Version: 1.0 In-Reply-To: <35FD53F367049845BC99AC72306C23D103E688B313E9@CNBJMBX05.corpusers.net> References: <35FD53F367049845BC99AC72306C23D103D6DB49161A@CNBJMBX05.corpusers.net> <20140924144520.697A8C40738@trevor.secretlab.ca> <35FD53F367049845BC99AC72306C23D103E688B313E7@CNBJMBX05.corpusers.net> <20141204100453.49DF2C40992@trevor.secretlab.ca> <35FD53F367049845BC99AC72306C23D103E688B313E9@CNBJMBX05.corpusers.net> From: Grant Likely Date: Thu, 4 Dec 2014 12:45:54 +0000 X-Google-Sender-Auth: 9XOo8fUHhw1TwKerNC5UPMGTxRs Message-ID: Subject: Re: [RFC] fdt:free the fdt reserved memory To: "Wang, Yalin" Cc: "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 4, 2014 at 10:23 AM, Wang, Yalin wrote: >> -----Original Message----- >> From: Grant Likely [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely >> Sent: Thursday, December 04, 2014 6:05 PM >> To: Wang, Yalin; 'robh+dt@kernel.org'; 'devicetree@vger.kernel.org'; >> 'pawel.moll@arm.com'; 'mark.rutland@arm.com'; >> 'ijc+devicetree@hellion.org.uk'; 'linux-kernel@vger.kernel.org' >> Subject: RE: [RFC] fdt:free the fdt reserved memory >> >> On Thu, 4 Dec 2014 14:56:11 +0800 >> , "Wang, Yalin" >> wrote: >> > > -----Original Message----- >> > > From: Grant Likely [mailto:glikely@secretlab.ca] On Behalf Of Grant >> > > Likely >> > > Sent: Wednesday, September 24, 2014 10:45 PM >> > > To: Wang, Yalin; 'robh+dt@kernel.org'; 'devicetree@vger.kernel.org'; >> > > 'pawel.moll@arm.com'; 'mark.rutland@arm.com'; >> > > 'ijc+devicetree@hellion.org.uk'; 'linux-kernel@vger.kernel.org' >> > > Subject: Re: [RFC] fdt:free the fdt reserved memory >> > > >> > > On Thu, 18 Sep 2014 17:25:12 +0800, "Wang, Yalin" >> > > wrote: >> > > > This patch make some change to unflatten_dt_node(), make sure the >> > > > device_node don't reference to fdt raw blob memory, so that we can >> > > > free the raw blob reserved memory after initcalls. >> > > > >> > > > Signed-off-by: Yalin Wang >> > > >> > > Do you have any measurements showing a change in available memory >> > > before and after the patch? >> > > >> > Does anyone have a look at this patch? >> > It can save 12K on my platform, >> > My dtb is 164K >> >> Yes, I've been thinking about this one. Unfortunately there is a conflict >> with another feature that I'm merging for v3.19. See commit 08d53aa5, >> "of/fdt: export fdt blob as /sys/firmware/fdt" in linux-next. >> That commit requires the original blob to be kept around. >> >> In order to free the original dtb, the /sys/firmware/fdt feature will need >> to be changed to let it be configured out. All things considered, that is >> probably the right thing to do, but doing so increases the memory load for >> the platforms that want /sys/firmware/fdt. I'd like to see what the impact >> would be on the code to switch to this method when /sys/firmware/fdt is >> configured out. >> > Oh, I understand, > If enable /sys/firmware/fdt feature patch, doesn't need > My patch is fine, > So need 2 method to unflatten dtb blob. I don't want to duplicate the function. It would instead need to be a build time configuration to the function that if /sys/firmware/fdt is enabled, then copying the property on unflatten is disabled. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/