Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbaLDOXN (ORCPT ); Thu, 4 Dec 2014 09:23:13 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:36436 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932238AbaLDOXL (ORCPT ); Thu, 4 Dec 2014 09:23:11 -0500 Date: Thu, 4 Dec 2014 15:23:04 +0100 From: Frederic Weisbecker To: Linus Torvalds Cc: Andy Lutomirski , Dave Jones , Linux Kernel , Richard Guy Briggs , Eric Paris , Oleg Nesterov , Paul McKenney , Thomas Gleixner , "H. Peter Anvin" Subject: Re: 3.18 nohz + audit regression (Re: [PATCH] context_tracking: Restore previous state in schedule_user) Message-ID: <20141204142301.GA3269@lerouge> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 03, 2014 at 08:58:46PM -0800, Linus Torvalds wrote: > On Wed, Dec 3, 2014 at 5:29 PM, Andy Lutomirski wrote: > > > > So, to summarize the choices for 3.18: > > > > 4. This patch. > > I've applied it. The alternatives look worse, and the patch doesn't > look bad. In many ways it looks better than the old user_exit/enter > pair, although obviously the "schedule_user()" name is kind of odd > now. Whatever. That doesn't look like the safest approach to me. Somehow I felt more comfortable with exception_enter/exit on the audit function. A few other archs use schedule_user() as well, it's likely fine but I'm not sure how subtle their path is. Besides, is it possible that the audit function gets called after syscall_trace_leave() or do_notify_resume()? If so, the patch won't fix the issue entirely. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/