Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754568AbaLDSP2 (ORCPT ); Thu, 4 Dec 2014 13:15:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46381 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253AbaLDSP0 (ORCPT ); Thu, 4 Dec 2014 13:15:26 -0500 Date: Thu, 4 Dec 2014 20:15:12 +0200 From: "Michael S. Tsirkin" To: Cornelia Huck Cc: linux-kernel@vger.kernel.org, Rusty Russell , David Hildenbrand , virtualization@lists.linux-foundation.org, Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 Message-ID: <20141204181512.GA24307@redhat.com> References: <1417713984-23771-1-git-send-email-mst@redhat.com> <1417713984-23771-3-git-send-email-mst@redhat.com> <20141204185914.4e989a7a.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141204185914.4e989a7a.cornelia.huck@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 04, 2014 at 06:59:14PM +0100, Cornelia Huck wrote: > On Thu, 4 Dec 2014 19:26:50 +0200 > "Michael S. Tsirkin" wrote: > > > What does it mean if rev 1 device does not set > > VIRTIO_F_VERSION_1? E.g. is it native endian? > > > > Let's not even try to drive such devices: > > skip attempts to finalize features or set status. > > Why not set status_failed? It might be cleanest to just teach core that finalize_features can fail. I'll look into this. > > virtio core will detect this and bail out. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/s390/kvm/virtio_ccw.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > I'm not sure yet whether I like this approach. I'll think about it over > the weekend. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/