Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933079AbaLDSnW (ORCPT ); Thu, 4 Dec 2014 13:43:22 -0500 Received: from mail-vc0-f176.google.com ([209.85.220.176]:42274 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215AbaLDSnU (ORCPT ); Thu, 4 Dec 2014 13:43:20 -0500 MIME-Version: 1.0 In-Reply-To: <20141204184046.GL7944@katana> References: <1415261514-4051-1-git-send-email-addy.ke@rock-chips.com> <1417574237-4328-1-git-send-email-addy.ke@rock-chips.com> <20141203111518.GB1039@katana> <20141204184046.GL7944@katana> Date: Thu, 4 Dec 2014 10:43:19 -0800 X-Google-Sender-Auth: 5rUOYghFS_RVLeYqFzLzhSmpbZ0 Message-ID: Subject: Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec From: Doug Anderson To: Wolfram Sang Cc: Addy Ke , Max Schwarz , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Olof Johansson , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , Eddie Cai , Jianqun Xu , Tao Huang , Chris , =?UTF-8?B?5aea5pm65oOF?= , han jiang , Kever Yang , Lin Huang , caesar , Shunqian Zheng Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfram, On Thu, Dec 4, 2014 at 10:40 AM, Wolfram Sang wrote: > >> If you don't read all the below, my belief is that we should simply >> rename the strings in Addy's patch. We should change "rise-ns" to >> "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time". >> Wolfram: can you confirm this is OK? I'm voting to leave the "-ns" >> off the end of both to avoid asymmetry. > > New binding should have the "-ns" suffix, right? So, I'd vote to add the > suffix to the new bindings and deprecate the ones used in the designware > driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns" > > It might be a little more work now, but it will help us in the future, > because it is the correct way to do it. OK, that sounds fair. You're OK with my proposal otherwise? Are you looking for Addy or me to submit a patch supporting the "-ns" suffix on the Designware i2c driver, or should we just use the "-ns" suffix in the Rockchip driver and assume someone will later add support for the new binding in the Designware i2c driver? -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/