Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933574AbaLEDGM (ORCPT ); Thu, 4 Dec 2014 22:06:12 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:38499 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932378AbaLEDGL (ORCPT ); Thu, 4 Dec 2014 22:06:11 -0500 Date: Wed, 3 Dec 2014 05:12:40 -0800 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] toshiba_acpi: Change notify funtion to handle more events Message-ID: <20141203131240.GD75099@vmdeb7> References: <1417675325-14921-1-git-send-email-coproscefalo@gmail.com> <1417675325-14921-3-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1417675325-14921-3-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote: > @@ -1971,41 +2008,22 @@ error: > static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event) > { > struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev); > - u32 hci_result, value; > - int retries = 3; > - int scancode; > - > - if (event != 0x80) > - return; > + int ret; CC drivers/platform/x86/toshiba_acpi.o drivers/platform/x86/toshiba_acpi.c: In function ‘toshiba_acpi_notify’: drivers/platform/x86/toshiba_acpi.c:2012:6: warning: unused variable ‘ret’ [-Wunused-variable] int ret; ^ Please compile check each patch. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/