Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933684AbaLEEUJ (ORCPT ); Thu, 4 Dec 2014 23:20:09 -0500 Received: from mail-lb0-f180.google.com ([209.85.217.180]:60302 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933462AbaLEEUH (ORCPT ); Thu, 4 Dec 2014 23:20:07 -0500 MIME-Version: 1.0 In-Reply-To: <20141204183242.GJ7944@katana> References: <1417610126-7957-1-git-send-email-harinik@xilinx.com> <1417610126-7957-2-git-send-email-harinik@xilinx.com> <20141204183242.GJ7944@katana> Date: Fri, 5 Dec 2014 09:50:04 +0530 Message-ID: Subject: Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers From: Harini Katakam To: Wolfram Sang Cc: Mark Rutland , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "vishnum@xilinx.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Dec 5, 2014 at 12:02 AM, Wolfram Sang wrote: > >> + /* >> + * If the device is sending data If there is further >> + * data to be sent. Calculate the available space >> + * in FIFO and fill the FIFO with that many bytes. >> + */ > > This comment looks broken. In general, I think there should be more > comments explaining why things have to be done this way. > There's some grammatical errors here. Let me correct it and add more comments. Regards, Harini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/