Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbaLEIkL (ORCPT ); Fri, 5 Dec 2014 03:40:11 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:44738 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbaLEIkJ (ORCPT ); Fri, 5 Dec 2014 03:40:09 -0500 X-IronPort-AV: E=Sophos;i="5.07,521,1413237600"; d="scan'208";a="111425923" Date: Fri, 5 Dec 2014 09:40:01 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Julia Lawall , Joe Perches , Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() In-Reply-To: <54816700.6090501@users.sourceforge.net> Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> <5480DBDE.7040604@users.sourceforge.net> <1417731809.2721.17.camel@perches.com> <5480DFB5.4090708@users.sourceforge.net> <1417733101.2721.20.camel@perches.com> <54816700.6090501@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Dec 2014, SF Markus Elfring wrote: > > Markus, are you sure that you cannot use netdev_warn in this case? > > No. - I did not become familiar enough with the software infrastructure around > the mppe_rekey() function. > > I do not see so far how I could determine a pointer for the first parameter there. > The data structure "ppp_mppe_state" (which is referenced by the input variable > "state") does not contain corresponding context information, does it? Indeed, I also don't see anything promising. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/