Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752377AbaLEM12 (ORCPT ); Fri, 5 Dec 2014 07:27:28 -0500 Received: from mail-wg0-f49.google.com ([74.125.82.49]:47129 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbaLEM1Z (ORCPT ); Fri, 5 Dec 2014 07:27:25 -0500 MIME-Version: 1.0 In-Reply-To: <20141205104009.GE11889@leverpostej> References: <1417692860-18841-1-git-send-email-chunyan.zhang@spreadtrum.com> <20141205104009.GE11889@leverpostej> Date: Fri, 5 Dec 2014 20:27:23 +0800 Message-ID: Subject: Re: [PATCH v4 0/5] Add Spreadtrum Sharkl64 Platform support From: Lyra Zhang To: Mark Rutland Cc: Chunyan Zhang , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "gnomes@lxorguk.ukuu.org.uk" , "broonie@kernel.org" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , Will Deacon , Catalin Marinas , "jslaby@suse.cz" , "jason@lakedaemon.net" , "heiko@sntech.de" , "florian.vaussard@epfl.ch" , "andrew@lunn.ch" , "rrichter@cavium.com" , "hytszk@gmail.com" , "grant.likely@linaro.org" , "orsonzhai@gmail.com" , "geng.ren@spreadtrum.com" , "zhizhou.zhang@spreadtrum.com" , "lanqing.liu@spreadtrum.com" , "wei.qiao@spreadtrum.com" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "linux-serial@vger.kernel.org" , "sprdlinux@freelists.org" , "linux-arm-kernel@lists.infradead.org" , allen.zhang@spreadtrum.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 5, 2014 at 6:40 PM, Mark Rutland wrote: > Hi, > > On Thu, Dec 04, 2014 at 11:34:15AM +0000, Chunyan Zhang wrote: >> Spreadtrum is a rapid growing chip vendor providing smart phone total solutions. >> >> Sharkl64 Platform is nominated as a SoC infrastructure that supports 4G/3G/2G >> standards based on ARMv8 multiple core architecture.Now we have only one >> SoC(SC9836) based on this Platform in developing. >> >> This patchset adds Sharkl64 support in arm64 device tree and the serial driver >> of SC9836-UART. >> >> This patchset also has patches which address "sprd" prefix and DT compatible >> strings for nodes which appear un-documented. >> >> This version code was tesed both on Fast Mode and sc9836-fpga board. >> We use the latest boot-wrapper-aarch64 as the bootloader. >> >> Changes from v3: >> * Addressed review comments: >> - Added the description of clock property for sc9836-uart >> - Revised the size of GICC to be 8KiB >> - Added another compatible string for psci-0.1 > > I had open questions on v3 regarding your PSCI imlpementation. You > mentioned that you are using the aarch64 bootwrapper, but your DT > describes PSCI 0.2, and the (upstream) bootwrapper does not implement > PSCI 0.2. Adding the old PSCI compatible string is _not_ sufficient if > you do not have a full PSCI 0.2 implementation. > > Given that PSCI 0.2 requires more functionality to be implemented, I'd > like to know that your implementation is spec-compliant (implementing > the mandatory functions, nters the kernel in the correct state, etc), > and that it has been tested. > > Would you be able to look at my comments from the last posting please? > > Thanks, > Mark. > -- Hi, Mark Ok, I'll check it again with our related engineers. Actually, I had read all of your comments carefully before sending each version of patches, and I replied you a few days early, I guess you may miss it :) If we just implemented psci-0.1 until now, can we submit this path without "compatible = "arm,psci-0.2"", but only with " compatible = "arm,psci" ". Thanks, Chunyan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/