Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbaLEN1b (ORCPT ); Fri, 5 Dec 2014 08:27:31 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:40393 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbaLEN1a (ORCPT ); Fri, 5 Dec 2014 08:27:30 -0500 Date: Fri, 5 Dec 2014 05:27:24 -0800 From: Jeremiah Mahler To: Athira Lekshmi Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers:watchdog: Fixed missing blank line warning Message-ID: <20141205132724.GA3837@hudson.localdomain> Mail-Followup-To: Jeremiah Mahler , Athira Lekshmi , linux-kernel@vger.kernel.org References: <1417784340-6013-1-git-send-email-andnlnbn18@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417784340-6013-1-git-send-email-andnlnbn18@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Athira, On Fri, Dec 05, 2014 at 06:29:00PM +0530, Athira Lekshmi wrote: > Fixed the checkpatch warning: > Missing a blank line after declarations > > Signed-off-by: Athira Lekshmi > --- > drivers/watchdog/mixcomwd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c > index be86ea3..03b7612e 100644 > --- a/drivers/watchdog/mixcomwd.c > +++ b/drivers/watchdog/mixcomwd.c > @@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data, > > for (i = 0; i != len; i++) { > char c; > + > if (get_user(c, data + i)) > return -EFAULT; > if (c == 'V') > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ There should be spaces between the tags in your subject line. For example, instead of "Drivers:watchdog:" use "Drivers: watchdog:". And the tags should be useful, I am not sure if "Drivers" adds much. I would probably just use "watchdog:" in this case. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/