Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbaLERzK (ORCPT ); Fri, 5 Dec 2014 12:55:10 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:50621 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbaLERzH (ORCPT ); Fri, 5 Dec 2014 12:55:07 -0500 Message-ID: <5481F178.9000306@suse.cz> Date: Fri, 05 Dec 2014 18:55:04 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Seth Jennings , Josh Poimboeuf , Jiri Kosina , Vojtech Pavlik , Steven Rostedt , Petr Mladek , Miroslav Benes , Masami Hiramatsu CC: Christoph Hellwig , Greg KH , Andy Lutomirski , live-patching@vger.kernel.org, x86@kernel.org, kpatch@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv5 2/3] kernel: add support for live patching References: <1417708411-23655-1-git-send-email-sjenning@redhat.com> <1417708411-23655-3-git-send-email-sjenning@redhat.com> In-Reply-To: <1417708411-23655-3-git-send-email-sjenning@redhat.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2014, 04:53 PM, Seth Jennings wrote: ... > --- /dev/null > +++ b/kernel/livepatch/core.c > @@ -0,0 +1,902 @@ ... > +static struct kobj_type klp_ktype_patch = { > + .sysfs_ops = &kobj_sysfs_ops, > + .default_attrs = klp_patch_attrs > +}; Hi, I seem to have only a single comment here. If I am looking correctly, the last put on this kobject will cause kobject_cleanup to generate a warning: "kobject: '%s' (%p): does not have a release() " "function, it is broken and must be fixed.\n", There should be some .release. IMO, this is a place where we will release the module with the patch. So the .release hook should contain something like a commented out module_put() with a pointer to klp_register_patch. (Or be empty at worst.) thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/