Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbaLESoe (ORCPT ); Fri, 5 Dec 2014 13:44:34 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:45491 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbaLESoc (ORCPT ); Fri, 5 Dec 2014 13:44:32 -0500 Date: Fri, 5 Dec 2014 18:44:18 +0000 From: Catalin Marinas To: Russell King - ARM Linux Cc: Will Deacon , "Wang, Yalin" , "'linux-mm@kvack.org'" , "'linux-kernel@vger.kernel.org'" , "'linux-arm-kernel@lists.infradead.org'" , "'linux-arm-msm@vger.kernel.org'" , Peter Maydell Subject: Re: [RFC v2] arm:extend the reserved mrmory for initrd to be page aligned Message-ID: <20141205184418.GF31222@e104818-lin.cambridge.arm.com> References: <35FD53F367049845BC99AC72306C23D103D6DB491609@CNBJMBX05.corpusers.net> <20140915113325.GD12361@n2100.arm.linux.org.uk> <20141204120305.GC17783@e104818-lin.cambridge.arm.com> <20141205120506.GH1630@arm.com> <20141205170745.GA31222@e104818-lin.cambridge.arm.com> <20141205172701.GW11285@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141205172701.GW11285@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 05, 2014 at 05:27:02PM +0000, Russell King - ARM Linux wrote: > On Fri, Dec 05, 2014 at 05:07:45PM +0000, Catalin Marinas wrote: > > From 8e317c6be00abe280de4dcdd598d2e92009174b6 Mon Sep 17 00:00:00 2001 > > From: Catalin Marinas > > Date: Fri, 5 Dec 2014 16:41:52 +0000 > > Subject: [PATCH] Revert "ARM: 8167/1: extend the reserved memory for initrd to > > be page aligned" > > > > This reverts commit 421520ba98290a73b35b7644e877a48f18e06004. There is > > no guarantee that the boot-loader places other images like dtb in a > > different page than initrd start/end. When this happens, such pages must > > not be freed. The free_reserved_area() already takes care of rounding up > > "start" and rounding down "end" to avoid freeing partially used pages. > > > > In addition to the revert, this patch also removes the arm32 > > PAGE_ALIGN(end) when calculating the size of the memory to be poisoned. > > which makes the summary line rather misleading, and I really don't think > we need to do this on ARM for the simple reason that we've been doing it > for soo long that it can't be an issue. I started this as a revert and then realised that it doesn't solve anything for arm32 without changing the poisoning. Anyway, if you are happy with how it is, I'll drop the arm32 part. As I said yesterday, the issue is worse for arm64 with 64K pages. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/