Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbaLEUM5 (ORCPT ); Fri, 5 Dec 2014 15:12:57 -0500 Received: from ida.rowland.org ([192.131.102.52]:50014 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751631AbaLEUMt (ORCPT ); Fri, 5 Dec 2014 15:12:49 -0500 Date: Fri, 5 Dec 2014 14:18:40 -0500 (EST) From: Alan Stern X-X-Sender: stern@ida.rowland.org To: Chuansheng Liu cc: bhelgaas@google.com, , , , , , , , Subject: Re: [PATCH] PCI: Add disabling pm async quirk for JMicron chips In-Reply-To: <1417763857-11993-1-git-send-email-chuansheng.liu@intel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Dec 2014, Chuansheng Liu wrote: > Some history from > commit e6b7e41cdd8c ("ata: Disabling the async PM for JMicron chip 363/361") > == > Since v3.15, the PM feature of async noirq > commit 76569faa62c4 ("PM / sleep: Asynchronous threads for resume_noirq") is introduced. > > Then Jay hit one system resuming issue that one of the JMicron controller > can not be powered up successfully. > > His device tree is like below: > +-1c.4-[02]--+-00.0 JMicron Technology Corp. JMB363 SATA/IDE Controller > | \-00.1 JMicron Technology Corp. JMB363 SATA/IDE Controller > > After investigation, we found the the Micron chip 363 included > one SATA controller(0000:02:00.0) and one PATA controller(0000:02:00.1), > these two controllers do not have parent-children relationship, > but the PATA controller only can be powered on after the SATA controller > has finished the powering on. > > If we enabled the async noirq(), then the below error is hit during noirq > phase: > pata_jmicron 0000:02:00.1: Refused to change power state, currently in D3 > Here for JMicron chip 363/361, we need forcedly to disable the async method. You know, this is exactly why device_pm_wait_for_dev() exists -- so that asynchronous power-management operations can wait for other devices even when there's no parent-child relation. You should try to use device_pm_wait_for_dev() instead of disabling async suspend/resume. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/