From: Pali =?utf-8?q?Roh=C3=A1r?= <pali.rohar@gmail.com>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: Re: [PATCH 0/3] Dell Airplane Mode Switch driver
Date: Fri, 5 Dec 2014 22:23:25 +0100
User-Agent: KMail/1.13.7 (Linux/3.18.0-031800rc5-generic; KDE/4.14.1; x86_64; ; )
Cc: Darren Hart <dvhart@infradead.org>, Alex Hung <alex.hung@canonical.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        "platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
        linux-kernel@vger.kernel.org
References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <201412052203.25016@pali> <94523420.RuhoUzmTQs@xps13>
In-Reply-To: <94523420.RuhoUzmTQs@xps13>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart2316358.gJvXKNfoBI";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201412052223.25059@pali>
Sender: linux-kernel-owner@vger.kernel.org

--nextPart2316358.gJvXKNfoBI
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Friday 05 December 2014 22:12:42 Gabriele Mazzotta wrote:
> On Friday 05 December 2014 22:03:24 Pali Roh=C3=A1r wrote:
> > On Friday 05 December 2014 21:53:10 Gabriele Mazzotta wrote:
> > > On Friday 05 December 2014 21:38:17 Pali Roh=C3=A1r wrote:
> > > > On Wednesday 03 December 2014 14:00:23 Darren Hart wrote:
> > > > > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Roh=C3=A1r=20
wrote:
> > > > > > Darren, I think that if we do not solve problem with
> > > > > > duplicate key events (in dell-wireless.c) we should
> > > > > > postpone these patches to later kernel version. It
> > > > > > is better to not have such regression as it confuse
> > > > > > software like NetworkManager which is widely used.
> > > > >=20
> > > > > OK, that's what I needed. Thanks. Ignore my previous
> > > > > request, you answered it here. I will drop
> > > > > dell-wireless.c and look for a combined solution from
> > > > > you and Alex for the next release.
> > > > >=20
> > > > > Thanks,
> > > >=20
> > > > And according to discussion about Side effect of
> > > > pressing special keys at [1] [2] we should not report
> > > > this wireless key event (as input device) to userspace.
> > > > And Alex's driver is doing that.
> > > >=20
> > > > [1] -
> > > > http://www.spinics.net/lists/platform-driver-x86/msg0592
> > > > 2.h tml [2] -
> > > > http://www.spinics.net/lists/platform-driver-x86/msg0592
> > > > 4.h tml
> > >=20
> > > Alex's patch is for those laptop whose BIOS only sends a
> > > notification to DELLABCE when Fn keys are pressed. His
> > > patch simply translates these ACPI notifications to
> > > KEY_RFKILL keypresses.
> >=20
> > Yes, and your last patch disables sending such KEY events to
> > userspace (in dell-wmi driver). BIOS already handle changes,
> > so key press should not be reported to userspace... [1]
> > (from previous email).
>=20
> This is not true if ARBT (with 1 as parameter) is called. When
> this is done, the BIOS stops managing the radio devices
> completely and reporting KEY_RFKILL to userspace becomes a
> necessity. I guess that the laptops on which this patch was
> tested behaved like mine after ARBT is called, given that the
> call was missing completely in the original patch.
>=20

Ok. It means that at least original Alex patch needs to be=20
reworked (so we will do not see duplicate events problem and=20
problem described in previous email).

But my other question is... If ARBT(1) is called then it disables=20
BIOS support for managing radio devices on your laptop. Why we=20
need patch which disabling useful functionality (=3D ability to=20
disable wifi rfkill)? We still do not have patch which can=20
correctly set rfkill state by software on laptops of your fn key=20
type.

> > > Correct if I'm wrong, but shouldn't his patch have no
> > > effects on your laptop? If I'm not wrong, CRBT returns 2
> > > on your laptop, so the input device is not even created.
> > > Am I missing something?
> > >=20
> > > Gabriele
> >=20
> > Yes, it has no effect for my laptop.

=2D-=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--nextPart2316358.gJvXKNfoBI
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAlSCIk0ACgkQi/DJPQPkQ1LYpACgyg/V/2CRuWl8Qgc1JznXHD/Z
C8MAoLAF9bC4mwfxCx0v+3ziON2mmSUX
=hUgh
-----END PGP SIGNATURE-----

--nextPart2316358.gJvXKNfoBI--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/