Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbaLEXNh (ORCPT ); Fri, 5 Dec 2014 18:13:37 -0500 Received: from aniota.com ([63.225.163.150]:1646 "EHLO aniota.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752871AbaLEXNc (ORCPT ); Fri, 5 Dec 2014 18:13:32 -0500 X-Greylist: delayed 2253 seconds by postgrey-1.27 at vger.kernel.org; Fri, 05 Dec 2014 18:13:31 EST Date: Fri, 5 Dec 2014 14:35:54 -0800 (PST) From: terry white To: joe@perches.com cc: linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() In-Reply-To: <1417766255.2721.43.camel@perches.com> Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> <5480DBDE.7040604@users.sourceforge.net> <1417731809.2721.17.camel@perches.com> <5480DFB5.4090708@users.sourceforge.net> <1417733101.2721.20.camel@perches.com> <54815C5F.8090702@users.sourceforge.net> <1417766255.2721.43.camel@perches.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... ciao: : on "12-4-2014" "Joe Perches" writ: : > Does it make sense to express such implementation details in the Linux : > coding style documentation more explicitly (besides the fact that this : > update suggestion was also triggered by a warning from the script : > "checkpatch.pl". : : Probably not. : : Overly formalized coding style rules are perhaps : more of a barrier to entry than most want. funny you should mention that. as nothing more than a casual observer, i'm noticing a "TIRED" sensation reading this thread. i have "0" confidence a "SERIOUS" participant's enthusiasm would remain untested. however, the "checkpatch.pl" warning suggests an assumed 'custom'. i can't tell if this a 'serious' issue, or "pickin' fly shit out of pepper". but from my reading of it, the "CODE" , and the "logic" driving it, is not the problem. season's best ... -- ... it's not what you see , but in stead , notice ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/