Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754210AbaLEXOh (ORCPT ); Fri, 5 Dec 2014 18:14:37 -0500 Received: from 1wt.eu ([62.212.114.60]:37098 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752895AbaLEXOg (ORCPT ); Fri, 5 Dec 2014 18:14:36 -0500 Date: Sat, 6 Dec 2014 00:14:29 +0100 From: Willy Tarreau To: Mariusz Gorski Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: panel: Remove magic numbers in LCD commands Message-ID: <20141205231429.GA3051@1wt.eu> References: <1417813843-7589-1-git-send-email-marius.gorski@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417813843-7589-1-git-send-email-marius.gorski@gmail.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote: > Get rid of magic numbers in LCD commands and replace them with defined > values, so that it's more obvious that the commands are doing. > > Signed-off-by: Mariusz Gorski I didn't remember I wrote something that awful! Obvious ack. Acked-by: Willy Tarreau Thanks, willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/