Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbaLFF3f (ORCPT ); Sat, 6 Dec 2014 00:29:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:60271 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaLFF3d (ORCPT ); Sat, 6 Dec 2014 00:29:33 -0500 Date: Fri, 05 Dec 2014 21:34:02 -0800 (PST) Message-Id: <20141205.213402.629192734867363303.davem@davemloft.net> To: LinoSanfilippo@gmx.de Cc: arnd@arndb.de, paul.gortmaker@windriver.com, w-lkml@lebenslange-mailadresse.de, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pxa168: close race between napi and irq activation From: David Miller In-Reply-To: <1417344576-4940-1-git-send-email-LinoSanfilippo@gmx.de> References: <1417344576-4940-1-git-send-email-LinoSanfilippo@gmx.de> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 05 Dec 2014 21:29:32 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lino Sanfilippo Date: Sun, 30 Nov 2014 11:49:36 +0100 > In pxa168_eth_open() the irqs are enabled before napi. This opens a tiny time > window in which the irq handler is processed, disables irqs but then is not able > to schedule the not yet activated napi, leaving irqs disabled forever (since > irqs are reenabled in napi poll function). > Fix this race by activating napi before irqs are activated. > > Signed-off-by: Lino Sanfilippo Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/