Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbaLFQnT (ORCPT ); Sat, 6 Dec 2014 11:43:19 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:52748 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbaLFQnS (ORCPT ); Sat, 6 Dec 2014 11:43:18 -0500 From: Rickard Strandqvist To: Johannes Weiner , Michal Hocko Cc: Rickard Strandqvist , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere Date: Sat, 6 Dec 2014 17:45:56 +0100 Message-Id: <1417884356-3086-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere. And move BUILD_BUG_ON() to the beginning of memcg_stat_show() instead. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- mm/memcontrol.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d6ac0e3..5e2f0f3 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4379,17 +4379,14 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v) } #endif /* CONFIG_NUMA */ -static inline void mem_cgroup_lru_names_not_uptodate(void) -{ - BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS); -} - static int memcg_stat_show(struct seq_file *m, void *v) { struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m)); struct mem_cgroup *mi; unsigned int i; + BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS); + for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) { if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account) continue; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/