Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431AbaLGVFS (ORCPT ); Sun, 7 Dec 2014 16:05:18 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:4779 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaLGVFN (ORCPT ); Sun, 7 Dec 2014 16:05:13 -0500 X-IronPort-AV: E=Sophos;i="5.07,534,1413237600"; d="scan'208";a="111937480" Date: Sun, 7 Dec 2014 22:05:10 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Jeremiah Mahler cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/20] TTY: fix misspelling of current function in string In-Reply-To: <20141207205437.GD5360@hudson.localdomain> Message-ID: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-20-git-send-email-Julia.Lawall@lip6.fr> <20141207205437.GD5360@hudson.localdomain> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 7 Dec 2014, Jeremiah Mahler wrote: > Julia, > > On Sun, Dec 07, 2014 at 08:21:01PM +0100, Julia Lawall wrote: > > Replace a misspelled function name by %s and then __func__. > > > > This was done using Coccinelle, including the use of Levenshtein distance, > > as proposed by Rasmus Villemoes. > > > > Signed-off-by: Julia Lawall > > > > --- > > The semantic patch is difficult to summarize, but is available in the cover > [...] > > @@ -1458,7 +1458,7 @@ static void rp_wait_until_sent(struct tty_struct *tty, int timeout) > > > > orig_jiffies = jiffies; > > #ifdef ROCKET_DEBUG_WAIT_UNTIL_SENT > > - printk(KERN_INFO "In RP_wait_until_sent(%d) (jiff=%lu)...\n", timeout, > > + printk(KERN_INFO "In %s(%d) (jiff=%lu)...\n", __func__, timeout, > > jiffies); > > printk(KERN_INFO "cps=%d...\n", info->cps); > > #endif > > > More printk, pr_info, I'm sure you get the idea :-) Well, these are drivers, so it should probably be dev_info, etc. I have the impression that satisfying checkpatch would require a more complicated change than the original patch. I would still find it better to makes these changes in another patch series. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/