Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbaLGWs2 (ORCPT ); Sun, 7 Dec 2014 17:48:28 -0500 Received: from mail-vc0-f181.google.com ([209.85.220.181]:35322 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbaLGWs1 (ORCPT ); Sun, 7 Dec 2014 17:48:27 -0500 MIME-Version: 1.0 In-Reply-To: <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> Date: Sun, 7 Dec 2014 23:48:26 +0100 Message-ID: Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string From: Richard Weinberger To: Julia Lawall Cc: Kukjin Kim , "kernel-janitors@vger.kernel.org" , linux@rasmusvillemoes.dk, Joe Perches , David Woodhouse , Brian Norris , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, "linux-mtd@lists.infradead.org" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 7, 2014 at 8:20 PM, Julia Lawall wrote: > Replace a misspelled function name by %s and then __func__. > > s3c2410 is the name of the file, but using the exact function name should > make it easier to connect the error message to the code. > > This was done using Coccinelle, including the use of Levenshtein distance, > as proposed by Rasmus Villemoes. > > Signed-off-by: Julia Lawall > > --- > The semantic patch is difficult to summarize, but is available in the cover > letter of this patch series. > > drivers/mtd/nand/s3c2410.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c > index 35aef5e..0a9c41f 100644 > --- a/drivers/mtd/nand/s3c2410.c > +++ b/drivers/mtd/nand/s3c2410.c > @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) > > cpu_type = platform_get_device_id(pdev)->driver_data; > > - pr_debug("s3c2410_nand_probe(%p)\n", pdev); > + pr_debug("%s(%p)\n", __func__, pdev); I think we can drop the line completely. We have ftrace to trace function calls... -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/