Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbaLHJBl (ORCPT ); Mon, 8 Dec 2014 04:01:41 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:33333 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbaLHJBk convert rfc822-to-8bit (ORCPT ); Mon, 8 Dec 2014 04:01:40 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 8 Dec 2014 10:01:40 +0100 Message-ID: Subject: Re: [V6 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: =?UTF-8?B?QmVhbiBIdW8g6ZyN5paM5paMIChiZWFuaHVvKQ==?= Cc: "dwmw2@infradead.org" , Brian Norris , Marek Vasut , "geert+renesas@glider.be" , "grmoore@altera.com" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "shijie8@gmail.com" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8 December 2014 at 09:50, Bean Huo 霍斌斌 (beanhuo) wrote: > This patch is based on the latest l2-mtd,I don't know if can pass? > I have one question is that about following code. > I have added our Mciron quad flag into spi_nor_ids[] table,but line over 80 characters, > If I divided one line into two lines,this will make spi_nor_ids[] table look ugly.I also find that > There are other venders configure line that also over 80 characters,such as Spansion,Catalyst. > So I don't divide my following configure line into two two lines,I don't know if this can > Be accepted? > > + { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_QUAD_READ) }, > + { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, > + { "n25q512ax3", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, > + { "n25q00", INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, Even the CodingStyle says exceeding 80 columns can be accepted: > Statements longer than 80 columns will be broken into sensible chunks, unless > exceeding 80 columns significantly increases readability and does not hide > information. Various hardware tables often happen to use more chars/line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/