Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753858AbaLHJQr (ORCPT ); Mon, 8 Dec 2014 04:16:47 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753392AbaLHJQm (ORCPT ); Mon, 8 Dec 2014 04:16:42 -0500 Message-ID: <54856C75.1050309@nod.at> Date: Mon, 08 Dec 2014 10:16:37 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Julia Lawall CC: Kukjin Kim , "kernel-janitors@vger.kernel.org" , linux@rasmusvillemoes.dk, Joe Perches , David Woodhouse , Brian Norris , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, "linux-mtd@lists.infradead.org" , LKML Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.12.2014 um 08:11 schrieb Julia Lawall: >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c >>> index 35aef5e..0a9c41f 100644 >>> --- a/drivers/mtd/nand/s3c2410.c >>> +++ b/drivers/mtd/nand/s3c2410.c >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) >>> >>> cpu_type = platform_get_device_id(pdev)->driver_data; >>> >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); >>> + pr_debug("%s(%p)\n", __func__, pdev); >> >> I think we can drop the line completely. >> We have ftrace to trace function calls... > > Should the "initialised ok" at the end of the function be remove as well? > > Will it be confusing if this cleanup is done in this function, but not in > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > example? Hmm, this driver seems to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/