Date: Mon, 8 Dec 2014 14:56:15 +0100
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter =?iso-8859-1?Q?H=FCwe?= <PeterHuewe@gmx.de>
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>,
        Ashley Lai <ashley@ashleylai.com>,
        Marcel Selhorst <tpmdd@selhorst.net>, christophe.ricard@gmail.com,
        josh.triplett@intel.com, linux-api@vger.kernel.org,
        linux-kernel@vger.kernel.org, Will Arthur <will.c.arthur@intel.com>,
        tpmdd-devel@lists.sourceforge.net,
        jason.gunthorpe@obsidianresearch.com,
        trousers-tech@lists.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH v8 6/8] tpm: TPM 2.0 baseline support
Message-ID: <20141208135615.GC30303@intel.com>
References: <1417559480-13757-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <1417559480-13757-7-git-send-email-jarkko.sakkinen@linux.intel.com>
 <547E7553.2050608@linux.vnet.ibm.com>
 <201412050013.19082.PeterHuewe@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201412050013.19082.PeterHuewe@gmx.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Dec 05, 2014 at 12:13:18AM +0100, Peter H?we wrote:
> Am Mittwoch, 3. Dezember 2014, 03:28:35 schrieb Stefan Berger:
> > On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
> > > +
> > > +/**
> > > + * tpm2_startup() - send startup command to the TPM chip
> > > + * @chip:		TPM chip to use.
> > > + * @startup_type	startup type. The value is either
> > > + *			TPM_SU_CLEAR or TPM_SU_STATE.
> > > + *
> > > + * 0 is returned when the operation is successful. If a negative number
> > > is + * returned it remarks a POSIX error code. If a positive number is
> > > returned + * it remarks a TPM error.
> > > + */
> > > +int tpm2_startup(struct tpm_chip *chip, __be16 startup_type)
> > > +{
> > > +	struct tpm2_cmd cmd;
> > > +
> > > +	cmd.header.in = tpm2_startup_header;
> > > +
> > > +	cmd.params.startup_in.startup_type = startup_type;
> > > +	return tpm_transmit_cmd(chip, &cmd, sizeof(cmd),
> > > +				"attempting to start the TPM");
> > > +}
> > 
> > I suppose you need to send this command because your firmware does not
> > do it ?Following TPM1.2 I guess the BIOS / UEFI should send this instead
> > and sending it later would actually be wrong. Hm, I don't find from
> > where you are calling this... do you need it ? Can you remove it?
> > 
> >     Stefan
> 
> Hi,
> 
> I think it would be good to send a TPM2_Startup if the TPM sends a 
> TPM_RC_INITIALIZE (0x100) - so it becomes atleast usable.
> Of course the BIOS/UEFI/Firmware should send the TPM2_Startup, but if there is 
> no such thing, I would prefer Linux to do it, rather than nobody.
> (analog: This was done for embedded platforms with TPM1.2).
> 
> In the current situation (v9) it is not possible to use the TPM2 on a machine 
> without bios integration. :( (so I cannot test here :( )

Should the place be if sending self-test fails? I think the type should
be TPM2_SU_CLEAR. Do you agree?

All other issues are now fixed except this and STS3 bit issue that I 
look for next. In my github there is tpm2-v10 branch now with fixes
on top. I squash the fixes right after these two remaining issues are
fixed.

> Peter

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/