Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755757AbaLHPWb (ORCPT ); Mon, 8 Dec 2014 10:22:31 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:54956 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752960AbaLHPWa (ORCPT ); Mon, 8 Dec 2014 10:22:30 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Ming Lei Subject: Re: wl1251: NVS firmware data Date: Mon, 8 Dec 2014 16:22:25 +0100 User-Agent: KMail/1.13.7 (Linux/3.18.0-031800rc5-generic; KDE/4.14.1; x86_64; ; ) Cc: Pavel Machek , "Greg Kroah-Hartman" , "John W. Linville" , Grazvydas Ignotas , "linux-wireless@vger.kernel.org" , Network Development , Linux Kernel Mailing List , Ivaylo Dimitrov , Aaro Koskinen , Kalle Valo , Sebastian Reichel , David Gnedt References: <201411271506.20457@pali> <201412061402.21514@pali> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6013142.Y7C6ce8dYc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201412081622.25541@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart6013142.Y7C6ce8dYc Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 08 December 2014 16:18:18 Ming Lei wrote: > On Sat, Dec 6, 2014 at 9:02 PM, Pali Roh=C3=A1r=20 wrote: > > On Saturday 06 December 2014 13:49:54 Pavel Machek wrote: > > /** > >=20 > > + * request_firmware_prefer_user: - prefer usermode helper > > for loading firmware + * @firmware_p: pointer to firmware > > image > > + * @name: name of firmware file > > + * @device: device for which firmware is being loaded > > + * > > + * This function works pretty much like request_firmware(), > > but it prefer + * usermode helper. If usermode helper fails > > then it fallback to direct access. + * Usefull for dynamic > > or model specific firmware data. + **/ > > +int request_firmware_prefer_user(const struct firmware > > **firmware_p, + const char *name, > > struct device *device) +{ > > + int ret; > > + __module_get(THIS_MODULE); > > + ret =3D _request_firmware(firmware_p, name, device, > > + FW_OPT_UEVENT | > > FW_OPT_PREFER_USER); + module_put(THIS_MODULE); > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(request_firmware_prefer_user); >=20 > I'd like to introduce request_firmware_user() which only > requests firmware from user space, and this way is simpler > and more flexible since we have request_firmware_direct() > already. >=20 > Thanks, > Ming Lei Ming, for wl1251 NVS data we need to load use usermode helper and=20 fallback to direct load. So I think it is better to handle this=20 request in firmware code and not in driver. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart6013142.Y7C6ce8dYc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlSFwjEACgkQi/DJPQPkQ1LiOwCfYDvcaBsb2UkGRzsc6RY/9zSb K5cAnj47jXkv66tvdcHMuFCFs2a0Itc2 =mV9Q -----END PGP SIGNATURE----- --nextPart6013142.Y7C6ce8dYc-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/