Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756033AbaLHQri (ORCPT ); Mon, 8 Dec 2014 11:47:38 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:62222 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755985AbaLHQrf (ORCPT ); Mon, 8 Dec 2014 11:47:35 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: "Greg Kroah-Hartman" Subject: Re: wl1251: NVS firmware data Date: Mon, 8 Dec 2014 17:47:30 +0100 User-Agent: KMail/1.13.7 (Linux/3.18.0-031800rc5-generic; KDE/4.14.1; x86_64; ; ) Cc: Ming Lei , Pavel Machek , "John W. Linville" , Grazvydas Ignotas , "linux-wireless@vger.kernel.org" , Network Development , Linux Kernel Mailing List , Ivaylo Dimitrov , Aaro Koskinen , Kalle Valo , Sebastian Reichel , David Gnedt References: <201411271506.20457@pali> <20141208163714.GA31169@kroah.com> In-Reply-To: <20141208163714.GA31169@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2863433.MEIlOLhU11"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201412081747.30965@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart2863433.MEIlOLhU11 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 08 December 2014 17:37:14 Greg Kroah-Hartman wrote: > On Mon, Dec 08, 2014 at 11:18:18PM +0800, Ming Lei wrote: > > On Sat, Dec 6, 2014 at 9:02 PM, Pali Roh=C3=A1r=20 wrote: > > > On Saturday 06 December 2014 13:49:54 Pavel Machek wrote: > > > /** > > >=20 > > > + * request_firmware_prefer_user: - prefer usermode helper > > > for loading firmware + * @firmware_p: pointer to firmware > > > image > > > + * @name: name of firmware file > > > + * @device: device for which firmware is being loaded > > > + * > > > + * This function works pretty much like > > > request_firmware(), but it prefer + * usermode helper. If > > > usermode helper fails then it fallback to direct access. > > > + * Usefull for dynamic or model specific firmware data. > > > + **/ > > > +int request_firmware_prefer_user(const struct firmware > > > **firmware_p, + const char > > > *name, struct device *device) +{ > > > + int ret; > > > + __module_get(THIS_MODULE); > > > + ret =3D _request_firmware(firmware_p, name, device, > > > + FW_OPT_UEVENT | > > > FW_OPT_PREFER_USER); + module_put(THIS_MODULE); > > > + return ret; > > > +} > > > +EXPORT_SYMBOL_GPL(request_firmware_prefer_user); > >=20 > > I'd like to introduce request_firmware_user() which only > > requests firmware from user space, and this way is simpler > > and more flexible since we have request_firmware_direct() > > already. >=20 > Why would a driver care about what program provides the > firmware? It shouldn't at all, and we want to get rid of the > userspace firmware loader, not encourage drivers to use it > "exclusively" at all. >=20 Do not remove it! Without userspace firmware loader it is=20 impossible to load dynamic firmware files. > So no, I don't want to see this, and I don't want drivers to > worry about this either. >=20 > greg k-h =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart2863433.MEIlOLhU11 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlSF1iIACgkQi/DJPQPkQ1LyLACdHXw6S16hVyS0LsoKxo3Y9IZV wpsAn3f2W3NalaEsPVMxdFZsypo5CVUt =HzB5 -----END PGP SIGNATURE----- --nextPart2863433.MEIlOLhU11-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/