Message-ID: <1418067685.2058.27.camel@x220>
Subject: Re: [PATCH 2/3] kconfig: remove undocumented type definition alias
 'boolean'
From: Paul Bolle <pebolle@tiscali.nl>
To: Christoph Jaeger <cj@linux.com>
Cc: Daniel Borkmann <dborkman@redhat.com>, yann.morin.1998@free.fr,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org
Date: Mon, 08 Dec 2014 20:41:25 +0100
In-Reply-To: <5485F923.3090301@redhat.com>
References: <cover.1418003065.git.cj@linux.com>
	  <1539c3778a0f3533942f69540a9b5b3d1f965bdc.1418003065.git.cj@linux.com>
	  <1418064660.2058.11.camel@x220> <1418066039.2058.19.camel@x220>
	 <5485F923.3090301@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-12-08 at 20:16 +0100, Daniel Borkmann wrote:
> On 12/08/2014 08:13 PM, Paul Bolle wrote:
> > On Mon, 2014-12-08 at 19:51 +0100, Paul Bolle wrote:
> >> This doesn't apply on next-20141208. What tree did you base this on?
> >
> > I got it to apply on next-20141208 by dropping the hunk for
> > arch/cris/arch-v32/drivers/Kconfig and by making (trivial) context
> > changes to the hunks for init/Kconfig and net/Kconfig.
> >
> > (My experience with actual maintainers is that they won't bother to do
> > that. Anyhow, Kconfig is basically unmaintained. And I don't know which
> > tree one should base ones Kconfig patches on.)
> 
> Well, I guess if in doubt then this could go into Andrew's tree. :)
> 
> > I'll muddle along...

Checking this on the in tree defconfig files gave me a few hundred, it
seems, errors like:
    net/switchdev/Kconfig:7: syntax error
    net/switchdev/Kconfig:6: unknown option "boolean"
    drivers/hwmon/pmbus/Kconfig:61: syntax error
    drivers/hwmon/pmbus/Kconfig:60: unknown option "boolean"
    drivers/usb/gadget/Kconfig:373: syntax error
    drivers/usb/gadget/Kconfig:372: unknown option "boolean" 
    drivers/usb/gadget/Kconfig:386: syntax error
    drivers/usb/gadget/Kconfig:385: unknown option "boolean"
    drivers/usb/gadget/Kconfig:404: syntax error
    drivers/usb/gadget/Kconfig:403: unknown option "boolean"
    drivers/usb/gadget/Kconfig:418: syntax error
    drivers/usb/gadget/Kconfig:417: unknown option "boolean"
    make[1]: *** [oldconfig] Error 1
    make: *** [oldconfig] Error 2

I assume these are uses of "boolean" added by trees merged in
next-20141208 after the tree that you based your patch on.

Well, it seems the treewide "boolean" cleanup should be done first.
Removing support for "boolean" could than be a second, separate step.
Just to ease review.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/