Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbaLHWze (ORCPT ); Mon, 8 Dec 2014 17:55:34 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:38653 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754919AbaLHWzb (ORCPT ); Mon, 8 Dec 2014 17:55:31 -0500 MIME-Version: 1.0 In-Reply-To: <20141007234224.GL16469@dtor-ws> References: <1412644321-27683-1-git-send-email-bjorn.andersson@sonymobile.com> <1412644321-27683-2-git-send-email-bjorn.andersson@sonymobile.com> <5433B843.5060200@smartplayin.com> <20141007233045.GD31125@sonymobile.com> <20141007234224.GL16469@dtor-ws> Date: Mon, 8 Dec 2014 14:55:30 -0800 Message-ID: Subject: Re: [PATCH 1/2] input: Add Qualcomm PM8941 power key driver From: Bjorn Andersson To: Dmitry Torokhov Cc: Bjorn Andersson , Kiran Padwal , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "Cavin, Courtney" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 7, 2014 at 4:42 PM, Dmitry Torokhov wrote: > On Tue, Oct 07, 2014 at 04:30:46PM -0700, Bjorn Andersson wrote: >> On Tue 07 Oct 02:54 PDT 2014, Kiran Padwal wrote: >> [..] >> > Shouldn't we unregister input device? >> > >> >> It's allocated with devm_input_allocate_device() so I assumed that it goes away >> upon the device being removed. Looking at input_register_device() seems to >> confirm that. > > Yes, devices allocated with devm_input_allocate_device() will be > unregistered and freed automatically. > > Thanks. > Hi Dmitry, Will you pick this up? (couldn't find it in linux-next...) Or is there anything else you need from me? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/