Message-ID: <1418088558.15957.5.camel@perches.com>
Subject: Re: [PATCH] staging: ion: ion_cma_heap: remove ion_cma_get_sgtable
From: Joe Perches <joe@perches.com>
To: Zeng Tao <prime.zeng@huawei.com>
Cc: gregkh@linuxfoundation.org, john.stultz@linaro.org, ccross@android.com,
        rebecca@android.com, fabio.estevam@freescale.com,
        tranmanphong@gmail.com, benjamin.gaignard@linaro.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Mon, 08 Dec 2014 17:29:18 -0800
In-Reply-To: <1418087980-221566-1-git-send-email-prime.zeng@huawei.com>
References: <1418087980-221566-1-git-send-email-prime.zeng@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-12-09 at 09:19 +0800, Zeng Tao wrote:
> Remove the temporary code ion_cma_get_sgtable,
> use dma_common_get_sgtable instead
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
[]
> @@ -91,7 +73,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!info->table)
>  		goto free_mem;
>  
> -	if (ion_cma_get_sgtable
> +	if (dma_common_get_sgtable
>  	    (dev, info->table, info->cpu_addr, info->handle, len))
>  		goto free_table;
>  	/* keep this for memory release */

somewhat unrelated trivia:

It'd conform a bit more to kernel style to
write this with at least one argument on the
same line as the function like:

	if (dma_common_get_sgtable(dev, info->table, info->cpu_addr,
				   info->handle, len))
		goto  free_table;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/