Message-ID: <1418107460.15957.9.camel@perches.com>
Subject: Re: [PATCH] input: edt-ft5x06: fixed a macro coding style issue
From: Joe Perches <joe@perches.com>
To: Asaf Vertz <asaf.vertz@tandemg.com>
Cc: dmitry.torokhov@gmail.com, LW@KARO-electronics.de, B38611@freescale.com,
        maksqwe1@ukr.net, jg1.han@samsung.com, linux@rasmusvillemoes.dk,
        fabf@skynet.be, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Mon, 08 Dec 2014 22:44:20 -0800
In-Reply-To: <20141209063456.GA15121@ubuntu>
References: <20141209063456.GA15121@ubuntu>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-12-09 at 08:34 +0200, Asaf Vertz wrote:
> Fixed a coding style error, macros with complex values should be
> enclosed in parentheses.
[]
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
[]
> @@ -849,10 +849,11 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
>  	return 0;
>  }
>  
> -#define EDT_ATTR_CHECKSET(name, reg) \
> +#define EDT_ATTR_CHECKSET(name, reg) { \
>  	if (pdata->name >= edt_ft5x06_attr_##name.limit_low &&		\
>  	    pdata->name <= edt_ft5x06_attr_##name.limit_high)		\
> -		edt_ft5x06_register_write(tsdata, reg, pdata->name)
> +		edt_ft5x06_register_write(tsdata, reg, pdata->name);	\
> +}

Any time you see a naked if (foo) bar in a macro
prefer to use a do while (0) like;

#define EDT_ATTR_CHECKSET(name, reg)					\
do {									\
	if (pdata->name >= edt_ft5x06_attr_##name.limit_low &&		\
	    pdata->name <= edt_ft5x06_attr_##name.limit_high)		\
		edt_ft5x06_register_write(tsdata, reg, pdata->name);	\
while (0)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/