Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756682AbaLILt3 (ORCPT ); Tue, 9 Dec 2014 06:49:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756654AbaLILt2 (ORCPT ); Tue, 9 Dec 2014 06:49:28 -0500 Message-ID: <5486E1BD.4040809@redhat.com> Date: Tue, 09 Dec 2014 12:49:17 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Paul Bolle CC: Christoph Jaeger , yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/3] kconfig: remove undocumented type definition alias 'boolean' References: <1539c3778a0f3533942f69540a9b5b3d1f965bdc.1418003065.git.cj@linux.com> <1418064660.2058.11.camel@x220> <1418066039.2058.19.camel@x220> <5485F923.3090301@redhat.com> <1418067685.2058.27.camel@x220> <1418070979.2058.52.camel@x220> <1418073300.2058.63.camel@x220> In-Reply-To: <1418073300.2058.63.camel@x220> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2014 10:15 PM, Paul Bolle wrote: > On Mon, 2014-12-08 at 21:36 +0100, Paul Bolle wrote: >> On Mon, 2014-12-08 at 20:41 +0100, Paul Bolle wrote: >>> Well, it seems the treewide "boolean" cleanup should be done first. >>> Removing support for "boolean" could than be a second, separate step. >>> Just to ease review. >> >> This appears to have no effect on the .config files I generated for the >> defconfig files in next-20141208. (After porting the patch and changing >> those last booleans to bool, that is.) So that's good. >> >> If you'd resend as two patches on top of linux-next, I might add an >> Acked-by: or a Tested-by:. > > My last mail on this series. To make sure the tree stays buildable that > second patch to drop support for 'boolean' should only be applied a > release or two after the cleanup patch has been applied. Otherwise we're > bound to run into fun build errors in linux-next, and even mainline, for > quite a few commits, aren't we? One tree still using boolean is all it > takes... Sounds like a good plan, thanks a lot for looking into it, Paul! Meanwhile, also checkpatch.pl could emit a deprecate warning in case a patch carries Kconfig code with 'boolean' in it, but I leave that up to Christoph to decide. ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/