Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbaLISpu (ORCPT ); Tue, 9 Dec 2014 13:45:50 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:37445 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbaLISpt (ORCPT ); Tue, 9 Dec 2014 13:45:49 -0500 Date: Tue, 09 Dec 2014 13:45:47 -0500 (EST) Message-Id: <20141209.134547.1067254735927828157.davem@davemloft.net> To: linux@rasmusvillemoes.dk Cc: grundler@parisc-linux.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tulip: Remove private "strncmp" From: David Miller In-Reply-To: <1417689040-14958-1-git-send-email-linux@rasmusvillemoes.dk> References: <1417689040-14958-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 09 Dec 2014 10:45:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Thu, 4 Dec 2014 11:30:40 +0100 > The comment says that the built-in strncmp didn't work. That is not > surprising, as apparently "str" semantics are not really what is > wanted (hint: de4x5_strncmp only stops when two different bytes are > encountered or the end is reached; not if either byte happens to be > 0). de4x5_strncmp is actually a memcmp (except for the signature and > that bytes are not necessarily treated as unsigned char); since only > the boolean value of the result is used we can just replace > de4x5_strncmp with memcmp. > > Signed-off-by: Rasmus Villemoes Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/