Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309AbaLIX1Y (ORCPT ); Tue, 9 Dec 2014 18:27:24 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:34175 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbaLIX1W (ORCPT ); Tue, 9 Dec 2014 18:27:22 -0500 MIME-Version: 1.0 In-Reply-To: <54875D99.6070301@linaro.org> References: <1418079900-4640-1-git-send-email-mcgrof@do-not-panic.com> <1418079900-4640-3-git-send-email-mcgrof@do-not-panic.com> <5486BBB1.3040405@linaro.org> <54875D99.6070301@linaro.org> From: "Luis R. Rodriguez" Date: Tue, 9 Dec 2014 15:27:00 -0800 X-Google-Sender-Auth: UbsU3D83yuLv8vbBt1BeOH27czw Message-ID: Subject: Re: [Xen-devel] [PATCH v3 2/2] x86, arm64, platform, xen, kconfig: add xen defconfig helper To: Julien Grall Cc: "H. Peter Anvin" , josh@joshtriplett.org, sam@ravnborg.org, Michal Marek , Randy Dunlap , Ian Campbell , kvm@vger.kernel.org, x86@kernel.org, "linux-kernel@vger.kernel.org" , mtosatti@redhat.com, Pekka Enberg , Fengguang Wu , Sasha Levin , David Rientjes , xen-devel@lists.xenproject.org, Borislav Petkov , David Vrabel , Benjamin Poirier Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 9, 2014 at 12:37 PM, Julien Grall wrote: > On 09/12/14 20:22, Luis R. Rodriguez wrote: >> On Tue, Dec 9, 2014 at 1:06 AM, Julien Grall wrote: >>> Hello Luis, >>> >>> On 08/12/2014 23:05, Luis R. Rodriguez wrote: >>>> >>>> diff --git a/kernel/configs/xen.config b/kernel/configs/xen.config >>>> new file mode 100644 >>>> index 0000000..0d0eb6d >>>> --- /dev/null >>>> +++ b/kernel/configs/xen.config >>>> +CONFIG_XEN_MCE_LOG=y >>> >>> >>> MCE is x86 specific. >> >> That's what I thought too but its available for arm64, so should we >> fix that Kconfig to depend on x86? > > Are you sure? On the Linus's repo I have: > > config XEN_MCE_LOG > bool "Xen platform mcelog" > depends on XEN_DOM0 && X86_64 && X86_MCE > > Anyway, the MCE interface in the hypervisor is implemented in arch/x86 > not in common code. OK I'll move to x86. >>>> +CONFIG_XEN_HAVE_PVMMU=y >>> >>> >>> We don't have PVMMU support on ARM. Shouldn't you move this config in >>> architecture specific code? >> >> If you are sure then yes. > > I'm 100% sure. MMU is handled by the hardware on ARM. > > Thinking a bit more about this option. CONFIG_XEN_HAVE_PVMMU can't be > selected by the user. It's automatically added per platform (for > instance see arch/x86/xen/Kconfig). > > So maybe it should not even appear in the one of the fragment configs? And I'll remove this one. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/