Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbaLJKDq (ORCPT ); Wed, 10 Dec 2014 05:03:46 -0500 Received: from ozlabs.org ([103.22.144.67]:41724 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbaLJKDp (ORCPT ); Wed, 10 Dec 2014 05:03:45 -0500 Message-ID: <1418205823.9279.8.camel@ellerman.id.au> Subject: Re: [RFC PATCH 5/8] perf probe powerpc: Allow matching against dot symbols From: Michael Ellerman To: "Naveen N. Rao" Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, acme@kernel.org, ananth@in.ibm.com Date: Wed, 10 Dec 2014 21:03:43 +1100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-12-09 at 23:04 +0530, Naveen N. Rao wrote: > Allow perf probe to work on powerpc ABIv1 without the need to specify the > leading dot '.' for functions. 'perf probe do_fork' works with this patch. > > Signed-off-by: Naveen N. Rao > --- > tools/perf/util/probe-event.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index d465f7c..174c22e 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2221,6 +2221,15 @@ static int probe_function_filter(struct map *map __maybe_unused, > num_matched_functions++; > return 0; > } > +#ifdef __powerpc64__ > + /* Allow matching against the dot variant */ > + if (sym->name[0] == '.' && looking_function_name[0] != '.' && > + (sym->binding == STB_GLOBAL || sym->binding == STB_LOCAL) && > + strcmp(looking_function_name, sym->name+1) == 0) { > + num_matched_functions++; > + return 0; > + } > +#endif As for the previous patch, I think this should be in an arch helper. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/