Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932694AbaLJSWz (ORCPT ); Wed, 10 Dec 2014 13:22:55 -0500 Received: from mail-qg0-f49.google.com ([209.85.192.49]:38411 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932414AbaLJSWx (ORCPT ); Wed, 10 Dec 2014 13:22:53 -0500 MIME-Version: 1.0 In-Reply-To: <54882324.10700@rock-chips.com> References: <1418093001-30443-1-git-send-email-lyz@rock-chips.com> <1418093001-30443-2-git-send-email-lyz@rock-chips.com> <54882324.10700@rock-chips.com> Date: Wed, 10 Dec 2014 19:22:52 +0100 Message-ID: Subject: Re: [PATCH v4 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY From: Romain Perier To: Yunzhi Li Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Doug Anderson , olof@lixom.net, Tao Huang , Chris Zhong , Eddie Cai , linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , Grant Likely , Rob Herring , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , devicetree Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > So,do you mean that I should rename the C source file as phy-rockchip-usb2.c > ? what I mean is that you can simply rename the kconfig entry to PHY_ROCKCHIP_USB. If you explain that it is for usb 2.0 in the description (as it is already the case), it is enough, no needs to put USB2 in the kconfig entry name :) Have a nice evening, Romain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/